This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] mips: Fix store/load gp registers to/from ucontext_t

From: Joseph Myers <joseph at codesourcery dot com>
To: Gordana Cmiljanovic <Gordana dot Cmiljanovic at imgtec dot com>
Cc: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
Date: Wed, 17 May 2017 15:24:57 +0000
Subject: Re: [PATCH] mips: Fix store/load gp registers to/from ucontext_t
Authentication-results: sourceware.org; auth=none
References: <655B60FB9854204DB1D72C498A631BB6013C7191E7@BADAG02.ba.imgtec.org> <alpine.DEB.2.20.1705171455270.15681@digraph.polyomino.org.uk>

Also: to store in / load from the right places, I'd expect you to need a 
4-byte offset on all the GPRs for big-endian, and when accessing other 
greg_t fields (in particular pc), so that the correct (low) part of each 
64-bit field is used.  I don't see such an offset in this patch.

I think that such a patch should be tested for all three ABIs, for both 
endiannesses, to provide confidence that the functions remain consistent 
with each other in all cases.  (For the 64-bit ABIs, it would be enough to 
verify that installed stripped shared libraries are unchanged before and 
after the patch; given that, it wouldn't be necessary to run the full 
testsuite for them.  But the full testsuite should be run for both BE and 
LE o32.)

-- 
Joseph S. Myers
joseph@codesourcery.com

Follow-Ups:
- RE: [PATCH] mips: Fix store/load gp registers to/from ucontext_t
  - From: Gordana Cmiljanovic

References:
- [PATCH] mips: Fix store/load gp registers to/from ucontext_t
  - From: Gordana Cmiljanovic
- Re: [PATCH] mips: Fix store/load gp registers to/from ucontext_t
  - From: Joseph Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]