Re: [PATCH] grp: testgrp should exit unsupported properly.

[Florian Weimer <fweimer at redhat dot com>]

On 04/20/2017 03:26 PM, Wainer dos Santos Moschetta wrote:
> On 20-04-2017 08:56, Florian Weimer wrote:
> > On 04/12/2017 11:01 PM, Wainer dos Santos Moschetta wrote:
> > > grp/testgrp should properly exit unsupported if getpweuid() returns
> > > NULL and it does not set errno since it indicates that tests are
> > > executed by a passwordless user.
> >
> > Shouldn't this be a regular FAIL?  We should assume that the user 
> > running the testsuite has a name.
>
> Is there a consensus about FAIL vs UNSUPPORTED?
>
> In https://sourceware.org/glibc/wiki/Testing/Testsuite you read:
> "EXIT_UNSUPPORTEDfrom<support/test-driver.h>is a magic exit status (77) 
> which indicates that the test is not supported on this particular system 
> (perhaps due to lack of hardware or kernel support detected at run time).".
>
> But I tend to think a test should exit unsupported if the environment 
> doesn't provide all requirements to execute the it properly.
>
> Giving a bit of context: I ran glibc's testsuite in an VM provided by a 
> cloud provider, which access is granted through SSH keys. Other tests 
> also exit FAIL due lack of user's password.

In your case, it's an environment issue.  But I think what you are 
proposing reduces the scope of the test itself, which is why I think 
this change is not appropriate.

Thanks,
Florian