This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Assume that dup3 is available

From: Andreas Schwab <schwab at linux-m68k dot org>
To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
Cc: libc-alpha at sourceware dot org
Date: Tue, 18 Apr 2017 00:01:16 +0200
Subject: Re: [PATCH] Assume that dup3 is available
Authentication-results: sourceware.org; auth=none
References: <20170413192548.BF5A040EBCF62@oldenburg.str.redhat.com> <91373be4-3688-abf4-628a-9a510e4c2678@linaro.org>

On Apr 17 2017, Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:

>> +	  __dup3 (_IO_fileno (result), fd,
>> +		  (result->_flags2 & _IO_FLAGS2_CLOEXEC) != 0
>> +		  ? O_CLOEXEC : 0);
>
> Shouldn't we check the result of __dup3 and act accordingly in this situation
> (basically EINTR and EMFILE)?

I don't think either is possible, since both descriptors are already
allocated.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

References:
- [PATCH] Assume that dup3 is available
  - From: Florian Weimer
- Re: [PATCH] Assume that dup3 is available
  - From: Adhemerval Zanella

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]