This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] resolv: Add test coverage for ns_name_unpack, ns_name_ntop

From: Florian Weimer <fweimer at redhat dot com>
To: GNU C Library <libc-alpha at sourceware dot org>
Date: Tue, 4 Apr 2017 18:17:33 +0200
Subject: Re: [PATCH] resolv: Add test coverage for ns_name_unpack, ns_name_ntop
Authentication-results: sourceware.org; auth=none
Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=fweimer at redhat dot com
Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 6526B1555A
Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6526B1555A
References: <79f30309-66ae-941f-2cc6-2b827ca8bd03@redhat.com>

On 04/03/2017 02:58 PM, Florian Weimer wrote:

This patch adds some basic test coverage for these two functions.

I hope that the patch itself is not controversial, but I want to give
folks to comment on the size of the test data input file.  I did not
make any attempt to manually reduce the included automatically-generated
tests.  The file size is 196 KiB, so it is still rather small compared
to the math test files.

Carlos O'Donell didn't see any problems with the test data size, so I'mgoing to commit this shortly.


Thanks,
Florian

References:
- [PATCH] resolv: Add test coverage for ns_name_unpack, ns_name_ntop
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]