This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Update wcsmbs tests to use the support test driver.
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: libc-alpha at sourceware dot org
- Date: Mon, 3 Apr 2017 11:39:36 -0300
- Subject: Re: [PATCH] Update wcsmbs tests to use the support test driver.
- Authentication-results: sourceware.org; auth=none
- References: <20170329135920.18316-1-wainersm@linux.vnet.ibm.com>
LGTM with just one remark below.
On 29/03/2017 10:59, Wainer dos Santos Moschetta wrote:
> Replaced test-skeleton.c with support/test-driver.c and
> adjusted the tests accordinly.
>
> Checked on x86_64.
>
> 2017-03-28 Wainer dos Santos Moschetta <wainersm@linux.vnet.ibm.com>
>
> * wcsmbs/tst-btowc.c: Import support/test-driver.c, remove
> TEST_FUNCTION macro, and adjust return of do_test function.
> return of do_test method.
> * wcsmbs/tst-mbrtowc2.c: Likewise.
> * wcsmbs/tst-mbsrtowcs.c: Likewise.
> * wcsmbs/tst-wchar-h.c: Likewise.
> * wcsmbs/tst-wcpncpy.c: Likewise.
> * wcsmbs/tst-wcrtomb.c: Likewise.
> * wcsmbs/tst-wcsnlen.c: Likewise.
> * wcsmbs/tst-wcstof.c: Likewise.
> ---
> wcsmbs/tst-btowc.c | 5 ++---
> wcsmbs/tst-mbrtowc2.c | 5 ++---
> wcsmbs/tst-mbsrtowcs.c | 5 ++---
> wcsmbs/tst-wchar-h.c | 5 ++---
> wcsmbs/tst-wcpncpy.c | 5 ++---
> wcsmbs/tst-wcrtomb.c | 5 ++---
> wcsmbs/tst-wcsnlen.c | 5 ++---
> wcsmbs/tst-wcstof.c | 5 ++---
> 8 files changed, 16 insertions(+), 24 deletions(-)
>
> diff --git a/wcsmbs/tst-btowc.c b/wcsmbs/tst-btowc.c
> index 00c9f23..6e7d1a7 100644
> --- a/wcsmbs/tst-btowc.c
> +++ b/wcsmbs/tst-btowc.c
> @@ -74,7 +74,7 @@ eof_test (void)
>
>
> /* Test the btowc() function for a few locales with known character sets. */
> -static int
> +int
> do_test (void)
> {
> int result = 0;
> @@ -173,5 +173,4 @@ do_test (void)
> return result;
> }
As for previous tests update, there is no need to change the static modifier
on the do_test functions.