This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Update elf tests to use the support test driver.


* Wainer dos Santos Moschetta:

> Side note: the original tst-tls-manydynamic.c code uses xpthread_*
> functions. So I had to include support/xthread.h to avoid its
> breakage. In test-skeleton.c you can see the following:
>
> #ifdef _PTHREAD_H
> # include <support/xthread.h>
> #endif  /* _PTHREAD_H */
>
> So I'm considering to add this same block in test-driver.c since it
> will ease the migration of tests that use xpthread_*. Any objection to
> this change?

#include <support/test-driver.c> really should remain at the end of
the file, so adding this preprocessor conditional to
support/test-driver.c will not have the desired effect.  Please add
the #include directive to the beginning of the file.

And I think less magic is generally better.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]