This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Update elf tests to use the support test driver.
- From: Florian Weimer <fw at deneb dot enyo dot de>
- To: Wainer dos Santos Moschetta <wainersm at linux dot vnet dot ibm dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Sat, 01 Apr 2017 08:58:02 +0200
- Subject: Re: [PATCH] Update elf tests to use the support test driver.
- Authentication-results: sourceware.org; auth=none
- References: <20170329151407.6476-1-wainersm@linux.vnet.ibm.com> <32f6acde-964a-172d-43d7-69514932aaba@linaro.org> <87mvc2scv8.fsf@mid.deneb.enyo.de> <a51ff7cf-7103-15aa-48ab-eacb1fcd6ccf@linux.vnet.ibm.com>
* Wainer dos Santos Moschetta:
> Side note: the original tst-tls-manydynamic.c code uses xpthread_*
> functions. So I had to include support/xthread.h to avoid its
> breakage. In test-skeleton.c you can see the following:
>
> #ifdef _PTHREAD_H
> # include <support/xthread.h>
> #endif /* _PTHREAD_H */
>
> So I'm considering to add this same block in test-driver.c since it
> will ease the migration of tests that use xpthread_*. Any objection to
> this change?
#include <support/test-driver.c> really should remain at the end of
the file, so adding this preprocessor conditional to
support/test-driver.c will not have the desired effect. Please add
the #include directive to the beginning of the file.
And I think less magic is generally better.