This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Update elf tests to use the support test driver.
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: libc-alpha at sourceware dot org
- Date: Thu, 30 Mar 2017 17:52:35 -0300
- Subject: Re: [PATCH] Update elf tests to use the support test driver.
- Authentication-results: sourceware.org; auth=none
- References: <20170329151407.6476-1-wainersm@linux.vnet.ibm.com>
LGTM with just a comment:
On 29/03/2017 12:14, Wainer dos Santos Moschetta wrote:
> Replaced test-skeleton.c with support/test-driver.c and
> adjusted the tests accordinly.
>
> Checked on x86_64.
>
> diff --git a/elf/next.c b/elf/next.c
> index 6a3670c..3a7dba9 100644
> --- a/elf/next.c
> +++ b/elf/next.c
> @@ -5,7 +5,7 @@ extern int successful_rtld_next_test (void);
> extern void *failing_rtld_next_use (void);
>
>
> -static int
> +int
> do_test (void)
> {
> int result;
> @@ -40,5 +40,4 @@ do_test (void)
> return result;
> }
There is no need to remove the static definition from this function and
for all other every tests which includes the test-driver.c (since it will
end up creating the main entrypoint anyway). I would avoid change it.