This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Correct __GNUC_PREREQ for __const__ and __noreturn__ attributes.


On Tue, Mar 21, 2017 at 2:01 AM, Carlos O'Donell <carlos@redhat.com> wrote:
> On 03/20/2017 01:52 PM, Kang-Che Sung wrote:
>> Although GCC 2.5 introduced 'const' and 'noreturn' function
>> attributes, the '__const__' and '__noreturn__' were not available
>> until 2.6.2. So check __GNU_PREREQ(2,7) for these.
>>
>> Note: I'm here only to correct an inaccurate info. Because I guess
>> very few people would use such an old compiler now, I'm not bothered to
>> test, nor add support for __attribute__((const)) just for it's sake.
>
> Kang-Che,
>
> So you did not test this change with a gcc-2.5 compiler?

No, I only correct this based on the ONEWS entries in gcc package...

https://gcc.gnu.org/viewcvs/gcc/trunk/gcc/ONEWS?view=markup

...and a ChangeLog entry dated 1994...

> Thu Nov 10 18:02:58 1994  Michael Meissner  <meissner@pasta.osf.org>
> * c-common.c (decl_attributes): Check for attributes with leading
> and trailing double underscores.

...and a source diff of 2.6.2 proving that "__const__" is added here:

https://ftp.gnu.org/old-gnu/gcc/Version2.diffs/gcc-2.6.1-2.6.2.diff.gz

(By the way, this is my first time submitting a patch for glibc. So
excuse if I did something wrong)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]