This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Patch 2 of 2 for ILP32 aarch64

From: Mike Frysinger <vapier at gentoo dot org>
To: Steve Ellcey <sellcey at caviumnetworks dot com>
Cc: Joseph Myers <joseph at codesourcery dot com>, libc-alpha <libc-alpha at sourceware dot org>
Date: Fri, 17 Mar 2017 00:08:49 -0400
Subject: Re: [PATCH] Patch 2 of 2 for ILP32 aarch64
Authentication-results: sourceware.org; auth=none
References: <1487781046.2866.153.camel@caviumnetworks.com> <alpine.DEB.2.20.1702221702490.8704@digraph.polyomino.org.uk> <1487879964.2866.181.camel@caviumnetworks.com> <alpine.DEB.2.20.1702240033550.6066@digraph.polyomino.org.uk> <1487980010.2866.198.camel@caviumnetworks.com>

On 24 Feb 2017 15:46, Steve Ellcey wrote:
> --- a/sysdeps/aarch64/preconfigure
> +++ b/sysdeps/aarch64/preconfigure
> @@ -1,6 +1,14 @@
>  case "$machine" in
>  aarch64*)
> +	abiflag=`$CC $CFLAGS $CPPFLAGS -E -dM -xc /dev/null`
>  	base_machine=aarch64

i know this file already has incorrect indentation style, but since
it only has two broken lines, can we fix it while we're here ?

> -	machine=aarch64
> +	case "$abiflag" in
> +		*"#define __ILP32__ 1"*) aarch64_config_abi=ilp32 ;;
> +		*) aarch64_config_abi=lp64 ;;
> +	esac

shouldn't this be a standard #if/#error style test rather than
grepping the raw cpp output ?
-mike

Attachment: signature.asc
Description: Digital signature

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]