This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] Add page tests to string/test-strnlen.
- From: Zack Weinberg <zackw at panix dot com>
- To: Wainer dos Santos Moschetta <wainersm at linux dot vnet dot ibm dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, DJ Delorie <dj at redhat dot com>
- Date: Wed, 15 Mar 2017 16:40:47 -0400
- Subject: Re: [PATCH v2] Add page tests to string/test-strnlen.
- Authentication-results: sourceware.org; auth=none
- References: <20170315180012.6170-1-wainersm@linux.vnet.ibm.com>
On Wed, Mar 15, 2017 at 2:00 PM, Wainer dos Santos Moschetta
<wainersm@linux.vnet.ibm.com> wrote:
> May be tricky for otimized implementations to handle strings around
> page boundary once, for instance, it is performed unaligned loads or
> when maxlen is used as a hint for vectorized loops. The test cases
> should unveil regression bugs on these cases.
>
> To some extend do_random_tests in string/test-strnlen tests strings
> placed at page end but it does not cover all cases. So this change
> adds tests which consists of placing strings of varying sizes ending
> at the page boundary. It also combines with different values of maxlen.
Please check you aren't duplicating tests done by string/stratcliff.c.
zw