This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] Fix test-errno issues


On 14 Mar 2017 17:26, Adhemerval Zanella wrote:
> +    if (ret == (rtype) -1 && (err == experr1 || err == experr2))	\

not a new issue exactly, but should be parens around experr1 & experr2

> +      fail = 0;								\
> +    else								\
> +      {									\
> +        fail = 1;							\
> +        if (ret != (rtype) -1)						\
> +          printf ("FAIL: " #syscall ": didn't fail as expected"		\
> +               " (return "prtype")\n", ret);				\

shouldn't these be indented with tabs ?

> +        else if (err == 0xdead)						\
> +          puts("FAIL: " #syscall ": didn't update errno\n");		\

missing parens before the (

don't need the \n since it's a puts
-mike

Attachment: signature.asc
Description: Digital signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]