Re: [PATCH v2] Test errno setup

[Stefan Liebler <stli at linux dot vnet dot ibm dot com>]

On 03/08/2017 05:20 PM, Zack Weinberg wrote:
> On 03/06/2017 09:42 PM, Yury Norov wrote:
> > On Mon, Mar 06, 2017 at 05:49:19PM -0300, Wainer dos Santos Moschetta wrote:
> > > LGTM.
> > Thanks. I don't have the write access to the glibc repo. Could you
> > (someone else) apply the patch?
>
> I have committed the patch.
>
> zw
Hi,

on s390 (31bit), I get the following fails:
FAIL: misc/test-errno:
FAIL: mlock: errno is: 12 (Cannot allocate memory) expected: 22 (Invalid 
argument)

FAIL: posix/test-errno:
FAIL: mlock: errno is: 12 (Cannot allocate memory) expected: 22 (Invalid 
argument)

Is it intended, that the same test is run twice?
Both are compiled with sysdeps/unix/sysv/linux/test-errno.c.
Or should there two different tests, one compiled
with posix/test-errno.c
and the other with sysdeps/unix/sysv/linux/test-errno.c?

Why is the test-errno added to tests in sysdeps/unix/sysv/linux/Makefile 
with:
ifeq ($(subdir),misc)
tests += test-errno
endif



Regarding mlock-syscall:
If the compat mlock syscall is used, it returns 12 (ENOMEM).
This is also observable if you compile and run the testcase with -m32 on 
a x86_64 system.


I've compiled and run posix/test-errno.c on my s390x system and
get the following error:
FAIL: setsockopt: errno is: 22 (Invalid argument) expected: 9 (Bad file 
descriptor)

sl=0xfdfa9170 before setsockopt syscall.
The test succeeds if I sl is initialized to zero.

Bye
Stefan