This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 0/2] Revised _ISOMAC testsuite patches
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Zack Weinberg <zackw at panix dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 8 Mar 2017 21:58:13 -0500
- Subject: Re: [PATCH 0/2] Revised _ISOMAC testsuite patches
- Authentication-results: sourceware.org; auth=none
- References: <5f5f007c-76bd-4389-788a-b888df879bb6@panix.com>
On 03/08/2017 11:30 AM, Zack Weinberg wrote:
> Here are a revised pair of patches to run most of the testsuite in
> _ISOMAC mode.
>
> The first one eliminates _IO_MTSAFE_IO from the public headers; this
> wants to be reviewed independently due to the potential consequences for
> very old code that actually uses <libio.h>, e.g. GCC 2.95 was mentioned
> in an earlier thread.
>
> The second patch is the meat of the change. I have done as much prep
> work as I think is safe in already-committed patches; I don't think it
> makes sense to try to break it up any further. I can't guarantee I have
> addressed all of the reviewers' comments on the previous iteration,
> please read carefully.
>
> What I *have* done is compare stripped installation trees before and
> after each patch. The attached tarball contains two files of
> `diffoscope --html` output. "install-01.html" compares before and after
> the _IO_MTSAFE_IO change, "install-12.html" compares before and after
> the _ISOMAC-testsuite change. I'm pleased to report that in both cases,
> there are no changes other than the expected change to the headers and a
> build timestamp change in nscd. (Note: diffoscope was patched to ignore
> mtime changes.)
I want to review this, but I can't get to this for another week. So please
don't get too frustrated :}
--
Cheers,
Carlos.