Re: [PATCH] Disable rest of sunrpc, too [V2]

[Zack Weinberg <zackw at panix dot com>]

On Thu, Feb 23, 2017 at 9:42 AM, Thorsten Kukuk <kukuk@suse.de> wrote:
>
> if the sunrpc code is disabled, we still build and install header
> files, rpcgen or librpcsvc.a by default.  That's bad because it
> prevents from installing a full replacement of glibc SunRPC code
> in the same place, an alternate directory has to be used, which
> means a lot of code has to be adjusted.

I endorse this in principle.

Could you please post a diff of the contents of the installation tree
before and after this patch?  That is, build glibc [without
--enable-obsolete-rpc] before the patch, install it in a scratch
directory, run `find $DESTDIR | LC_ALL=C sort > /tmp/before-tree.txt`,
apply the patch, rebuild, reinstall,  `find $DESTDIR | LC_ALL=C sort >
/tmp/after-tree.txt`, and post diff -u of before-tree.txt /
after-tree.txt.  That will make it easier for people not already
familiar with what the sunrpc code installs to understand what the
patch does.

Your NEWS entry appears to be backward, and it doesn't mention the headers.

> +* rpcgen and librpcsvc.a will now only be build if
> +  obsolete-rpc configuration is disabled. Alternative
> +  sources can be found at https://github.com/thkukuk/rpcsvc-proto.

I think you meant "rpcgen, librpcsvc, and certain Sun RPC-related
headers will now only be built and installed when glibc is configured
with --enable-obsolete-rpc."

I also anticipate RMS yelling at us for linking to Github - would it
be possible for you to mirror your code onto savannah.gnu.org or
sourceware.org?

zw