This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: RFC: Run libm tests separately for each function
On Fri, 17 Feb 2017, Zack Weinberg wrote:
> Please go ahead and back out the changes to
> sysdeps/x86_64/fpu/math-tests-arch.h and
> sysdeps/x86_64/multiarch/test-multiarch.h. Those two changes seemed
> like they would be safe by themselves, although they're only
> _necessary_ in the context of my larger patchset, but I guess not.
Done thus. Committed.
Revert header inclusion changes that break math/ testing on x86_64.
2017-02-17 Joseph Myers <joseph@codesourcery.com>
Revert:
2017-02-16 Zack Weinberg <zackw@panix.com>
* sysdeps/x86_64/fpu/math-tests-arch.h: Include cpu-features.h.
Don't include init-arch.h.
* sysdeps/x86_64/multiarch/test-multiarch.h: Include cpu-features.h.
Don't include init-arch.h.
diff --git a/sysdeps/x86_64/fpu/math-tests-arch.h b/sysdeps/x86_64/fpu/math-tests-arch.h
index 9278e34..98f7cf6 100644
--- a/sysdeps/x86_64/fpu/math-tests-arch.h
+++ b/sysdeps/x86_64/fpu/math-tests-arch.h
@@ -16,11 +16,11 @@
License along with the GNU C Library; if not, see
<http://www.gnu.org/licenses/>. */
-#include <cpu-features.h>
-
#if defined REQUIRE_AVX
+# include <init-arch.h>
# define INIT_ARCH_EXT
+
# define CHECK_ARCH_EXT \
do \
{ \
@@ -29,8 +29,10 @@
while (0)
#elif defined REQUIRE_AVX2
+# include <init-arch.h>
# define INIT_ARCH_EXT
+
# define CHECK_ARCH_EXT \
do \
{ \
@@ -39,8 +41,10 @@
while (0)
#elif defined REQUIRE_AVX512F
+# include <init-arch.h>
# define INIT_ARCH_EXT
+
# define CHECK_ARCH_EXT \
do \
{ \
diff --git a/sysdeps/x86_64/multiarch/test-multiarch.c b/sysdeps/x86_64/multiarch/test-multiarch.c
index 597d64e..3974842 100644
--- a/sysdeps/x86_64/multiarch/test-multiarch.c
+++ b/sysdeps/x86_64/multiarch/test-multiarch.c
@@ -16,7 +16,7 @@
License along with the GNU C Library; if not, see
<http://www.gnu.org/licenses/>. */
-#include <cpu-features.h>
+#include <init-arch.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
--
Joseph S. Myers
joseph@codesourcery.com