This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/2] tunables: Fix environment variable processing for setuid binaries
- From: Carlos O'Donell <carlos at redhat dot com>
- To: siddhesh at sourceware dot org, Florian Weimer <fweimer at redhat dot com>, libc-alpha at sourceware dot org
- Date: Wed, 1 Feb 2017 00:01:55 -0500
- Subject: Re: [PATCH 1/2] tunables: Fix environment variable processing for setuid binaries
- Authentication-results: sourceware.org; auth=none
- References: <1485709870-25804-1-git-send-email-siddhesh@sourceware.org> <1485709870-25804-2-git-send-email-siddhesh@sourceware.org> <51584556-1411-112c-cc30-d19c93b1298b@redhat.com> <3a438975-d6e5-304a-7328-a60e7b6a6555@sourceware.org>
On 01/31/2017 11:53 PM, Siddhesh Poyarekar wrote:
> On Tuesday 31 January 2017 10:21 PM, Florian Weimer wrote:
>> This does not quite work because the next read position is not updated,
>> although the tunable definition in the input string has been moved. As
>> a result, a subsequent tunable is not recognized and applied or filtered.
>
> Ugh right, I'll post an updated patch.
We really need a GLIBC_PRIVATE get/set API for regression testing all of
these changes. Work for 2.26 I guess.
--
Cheers,
Carlos.