This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2.25] powerpc: Avoid calling strncmp via PLT on GCC 7
- From: "Tulio Magno Quites Machado Filho" <tuliom at linux dot vnet dot ibm dot com>
- To: Florian Weimer <fw at deneb dot enyo dot de>
- Cc: libc-alpha at sourceware dot org, joseph at codesourcery dot com, acsawdey at linux dot vnet dot ibm dot com, segher at kernel dot crashing dot org, siddhesh at sourceware dot org
- Cc:
- Date: Tue, 17 Jan 2017 15:23:14 -0200
- Subject: Re: [PATCH 2.25] powerpc: Avoid calling strncmp via PLT on GCC 7
- Authentication-results: sourceware.org; auth=none
- References: <1484573359-7879-1-git-send-email-tuliom@linux.vnet.ibm.com> <87wpduvgx8.fsf@mid.deneb.enyo.de>
Florian Weimer <fw@deneb.enyo.de> writes:
> [ text/plain ]
> * Tulio Magno Quites Machado Filho:
>
>> +/* GCC 7.0 added support for a builtin strncmp that is used on POWER >= 7. */
>> +#if !defined __ASSEMBLER__ && IS_IN (libc) && defined SHARED \
>> + && defined _ARCH_PWR7
>> +asm ("strncmp = __GI_strncmp");
>> +#endif
>
> Would it be safe to do this unconditionally, in the generic header?
Do you mean without _ARCH_PWR7?
If so, I think that's possible and in the generic header.
If this issue won't be fixed in GCC, I'll make that change here.
--
Tulio Magno