This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Rename strdup uses
On Thu, 12 Jan 2017, Wilco Dijkstra wrote:
> Joseph Myers wrote:
> > On Wed, 11 Jan 2017, Wilco Dijkstra wrote:
> >
> > > Rename existing uses of str(n)dup to __str(n)dup so it no longer needs
> > > to be redirected to a builtin. Also building GLIBC with -Os now no
> > > longer shows localplt or linkname space failures. Although this means a
> >
> > If this fixes such failures then [BZ #15105] and [BZ #19463] should be
> > included in the ChangeLog entry (if it fixes *all* such failures, then
> > additionally the bugs would be resolved as FIXED with milestone set once
> > this is in).
>
> Yes it fixes a few of those failures, but there are plenty left. I think most are due
> to disabling inlines with -Os (rather than using __extern_always_inline).
> The question is it worth trying to fix these too?
Yes, they should be fixed. The appropriate fix would need to be
considered case by case - whether it's making the functions always inline,
or always inline when building glibc, or arranging for hidden_proto /
hidden_def to be used for the non-inlined function calls.
--
Joseph S. Myers
joseph@codesourcery.com