This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] Remove index defines

On Wed, 11 Jan 2017, Wilco Dijkstra wrote:

> OK here is a new version that also removes index from hurd and sunrpc:
> 
> As a minor cleanup remove the (r)index defines from include/string.h as
> they are only used internally in a few places.  Rename all uses that 
> occur in GLIBC to str(r)chr.
> 
> ChangeLog:
> 2017-01-11  Wilco Dijkstra  <wdijkstr@arm.com>
> 
> 	* hurd/path-lookup.c (file_name_path_scan): Rename index to strchr.
> 	* include/string.h (index): Remove define.
> 	(rindex): Likewise.
> 	* misc/getttyent.c (__getttyent): Rename index to strchr.
> 	* misc/ttyslot.c (ttyslot): Rename rindex to strrchr.
> 	* sunrpc/rpc_main.c (mkfile_output): Likewise.

OK for 2.26 (as it's not a bug fix I see no need for it during the 
freeze).

-- 
Joseph S. Myers
joseph@codesourcery.com
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]