This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH COMMITTED] Do not require memset elimination in explicit_bzero test


On 12/20/2016 11:09 AM, Florian Weimer wrote:
Some targets fail to apply dead store elimination to the
memset call in setup_ordinary_clear.  Before this commit,
this causes the test case to fail.  Instead, the test case
now logs lack of memset elimination as an informational
message.

2016-12-20  Florian Weimer  <fweimer@redhat.com>

	Do not require memset elimination in explicit_bzero test.
	* string/tst-xbzero-opt.c (prepare_test_buffer): Force inlining.
	(enum test_expectation): Add NO_EXPECTATIONS.
	(subtests): NO_EXPECTATIONS for ordinary clear.
	(check_test_buffer): Handle NO_EXPECTATIONS.
	* string/Makefile (CFLAGS-tst-xbzero-opt.c): Compile with -O3.

Stefan, this test still fails for me on s390x:

PASS: no clear/prepare: expected 32 got 32
PASS: no clear/test: expected some got 32
PASS: ordinary clear/prepare: expected 32 got 32
INFO: ordinary clear/test: found 0 patterns (memset not eliminated)
PASS: explicit clear/prepare: expected 32 got 32
FAIL: explicit clear/test: expected 0 got 1

Do you have an idea what's going on there?

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]