This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 02/12] Do not stack-protect ifunc resolvers.


On 12/15/2016 01:34 PM, Nick Alcock wrote:
On 15 Dec 2016, Florian Weimer verbalised:

On 11/28/2016 01:32 PM, Nix wrote:
diff --git a/config.h.in b/config.h.in
index 1b58612..b42c4d8 100644
--- a/config.h.in
+++ b/config.h.in
@@ -48,6 +48,10 @@
 /* Define if compiler accepts -ftree-loop-distribute-patterns.  */
 #undef  HAVE_CC_INHIBIT_LOOP_TO_LIBCALL

+/* Define if compiler accepts -fno-stack-protector in an
+   __attribute__((__optimize__)).  */

Space after __attribute__; at least that's the current style.

OK. (But note that there is another instance of this problem elsewhere
in the same file, only a few lines above, in HAVE_SECTION_QUOTES: I
was copying it, for consistency.)

Oh. Yes, the style has changed over the years. Previously, you needed to look at the type of the preceding identifier to determine if a space is inserted. __attribute__ was treated like a macro and did not trigger insertion of a space.

+#undef	HAVE_CC_NO_STACK_PROTECTOR
+
 /* The level of stack protection in use for glibc as a whole.  */
 #undef	STACK_PROTECTOR_LEVEL

I don't have STACK_PROTECTOR_LEVEL in my sources, so this patch does not apply.  Did you post the sequence in the right order?

Ooof, patch 1 is missing due to a git commit ID foulup. This, of course,
renumbers all the later patches -- but here it is anyway, so you can
apply the series as a whole:

Okay, got it now. Initial build and test run of the whole series was successful. Back to reviewing the patches …

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]