This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3] Improve strtok(_r) performance
- From: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>
- To: "Gabriel F. T. Gomes" <gftg at linux dot vnet dot ibm dot com>
- Cc: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, nd <nd at arm dot com>
- Date: Wed, 14 Dec 2016 18:04:25 +0000
- Subject: Re: [PATCH v3] Improve strtok(_r) performance
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Wilco dot Dijkstra at arm dot com;
- Nodisclaimer: True
- References: <AM5PR0802MB26100973E7CD85F85C2C4351839B0@AM5PR0802MB2610.eurprd08.prod.outlook.com>,<20161214154337.38b8cac2@keller>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
Gabriel F. T. Gomes wrote:
>
> Could this have broken string/test-rawmemchr ?
Well the test passes for me, even if I disable AArch64 rawmemchr.S.
> I am seeing several lines like this:
>
> string/test-rawmemchr: Iteration 108 - wrong result in function __rawmemchr_ppc (10, 65, 140, 5) (nil) != 0x3fffa2effe0f, p 0x3fffa2effe00
Since rawmemchr now defers to memchr, could there be an issue in memchr? It seems to return NULL, which is not possible.
Wilco