This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [GLIBC][PATCH v2] Remove strdup inlines

From: Mike Frysinger <vapier at gentoo dot org>
To: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>
Cc: Zack Weinberg <zackw at panix dot com>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, nd <nd at arm dot com>
Date: Mon, 12 Dec 2016 11:32:54 -0500
Subject: Re: [GLIBC][PATCH v2] Remove strdup inlines
Authentication-results: sourceware.org; auth=none
References: <AM5PR0802MB26104922C496F25DABAFC47283980@AM5PR0802MB2610.eurprd08.prod.outlook.com> <CAKCAbMh4uqH+7XLA4iRKohu_JPCKCJjxm0G+sDjVayxSgXxWXg@mail.gmail.com> <AM5PR0802MB2610771B31B5E13D39AFB89483980@AM5PR0802MB2610.eurprd08.prod.outlook.com>

On 12 Dec 2016 13:02, Wilco Dijkstra wrote:
> --- a/string/string.h
> +++ b/string/string.h
>  
> +#if (defined __USE_XOPEN_EXTENDED || defined __USE_XOPEN2K8     \
> +     || __GLIBC_USE (LIB_EXT2))
> +# define strdup(s) __builtin_strdup (s)
> +#endif
> +
> +#if defined __USE_XOPEN2K8 || __GLIBC_USE (LIB_EXT2)
> +#define strndup(s,n) __builtin_strndup (s, n)
> +#endif

why do we need these at all ?  these seem like the sort of thing that
gcc should do automatically for us ?

2nd #define is missing an indent
-mike

Attachment: signature.asc
Description: Digital signature

Follow-Ups:
- Re: [GLIBC][PATCH v2] Remove strdup inlines
  - From: Wilco Dijkstra
- Re: [GLIBC][PATCH v2] Remove strdup inlines
  - From: Joseph Myers

References:
- [GLIBC][PATCH] Remove strdup inlines
  - From: Wilco Dijkstra
- Re: [GLIBC][PATCH] Remove strdup inlines
  - From: Zack Weinberg
- Re: [GLIBC][PATCH v2] Remove strdup inlines
  - From: Wilco Dijkstra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]