This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Convert signal.h from __need macros to bits/types/ headers.

From: Zack Weinberg <zackw at panix dot com>
To: Joseph Myers <joseph at codesourcery dot com>
Cc: libc-alpha at sourceware dot org
Date: Tue, 6 Dec 2016 11:39:24 -0500
Subject: Re: [PATCH] Convert signal.h from __need macros to bits/types/ headers.
Authentication-results: sourceware.org; auth=none
References: <20161206134825.25301-1-zackw@panix.com> <alpine.DEB.2.20.1612061633120.16077@digraph.polyomino.org.uk>

On 12/06/2016 11:34 AM, Joseph Myers wrote:
> On Tue, 6 Dec 2016, Zack Weinberg wrote:
> 
>> -  if (dest == NULL || left == NULL || right == NULL)
>> +  if (!dest || !left || !right)
> 
> glibc style avoids implicit boolean conversions, so prefers == NULL here 
> and anywhere else in the patch making such a change.

Ugh.  But consider it fixed in my tree.

zw

References:
- [PATCH] Convert signal.h from __need macros to bits/types/ headers.
  - From: Zack Weinberg
- Re: [PATCH] Convert signal.h from __need macros to bits/types/ headers.
  - From: Joseph Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]