Re: [PATCH] Install libm.a as linker script [BZ #20539]

[Andrew Senkevich <andrew dot n dot senkevich at gmail dot com>]

2016-12-05 23:01 GMT+03:00 H.J. Lu <hjl.tools@gmail.com>:
> On Mon, Dec 5, 2016 at 11:39 AM, Andrew Senkevich
> <andrew.n.senkevich@gmail.com> wrote:
>> 2016-10-25 1:02 GMT+03:00 H.J. Lu <hjl.tools@gmail.com>:
>> . . .
>>>
>>> Do you need to update rules for building static math tests with
>>> libmvec.a?
>>
>> Currently where are no static tests linked with libmvec.
>> Should we add such tests?
>
> It is probably OK without it for now.
>
>> Current patch is:
>>
>> diff --git a/Makerules b/Makerules
>> index e865782..a670f81 100644
>> --- a/Makerules
>> +++ b/Makerules
>> @@ -1190,7 +1190,10 @@ $(addprefix $(inst_sbindir)/,$(install-sbin)): \
>>   $(do-install-program)
>>  endif
>>  ifdef install-lib
>> -install-lib.a := $(filter lib%.a,$(install-lib))
>> +ifeq ($(build-mathvec),yes)
>> +install-lib.a := $(filter-out libm.a,$(filter lib%.a,$(install-lib)))
>> +install-lib.a := $(filter-out $(install-lib-ldscripts),$(install-lib.a))
>> +endif
>
> Will just
>
> ++ b/Makerules
> @@ -1191,6 +1191,7 @@ $(addprefix $(inst_sbindir)/,$(install-sbin)): \
>  endif
>  ifdef install-lib
>  install-lib.a := $(filter lib%.a,$(install-lib))
> +install-lib.a := $(filter-out $(install-lib-ldscripts),$(install-lib.a))
>  install-lib-non.a := $(filter-out lib%.a,$(install-lib))
>  ifdef install-lib-non.a
>  $(addprefix $(inst_libdir)/$(libprefix),$(install-lib-non.a)): \
>
> work?

Yes, indeed.

Attached fixed with updated ChangeLog, Ok for trunk?


--
WBR,
Andrew

Attachment: bz20539.patch
Description: Binary data