This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3] Remove defines to builtins in string2.h
On Wed, 23 Nov 2016, Wilco Dijkstra wrote:
> Florian Weimer wrote:
> > On 11/22/2016 10:15 PM, Wilco Dijkstra wrote:
> > > Yes there is overlap with this patch: https://sourceware.org/ml/libc-alpha/2016-11/msg00586.html
> > > (a previous version of that was posted back in February...). This particular
> > > change could be rolled back into the original strchr patch to avoid this conflict.
> >
> > Please consolidate the two into a single patch, and make sure it applies
> > before resubmitting it.
> >
> > We really should test this patch on x86 and s390.
>
> Unfortunately it looks like it'll need my strsep and strtok patches too,
> ie. it'll become a huge patch with many diffs in GLIBC, so testing it
> causes no unexpected changes on several targets would become a huge
> amount of work.
Well, you can always repost / ping those patches as an alternative to
combining them. But in any case, if posting a patch that depends on a
previous one but isn't posted as part of the same series as it, *make sure
the posting lists all the dependencies explicitly* (this includes if the
dependency is only textual rather than logical and you could in fact apply
the patches out of order with some fixups if approved out of order).
--
Joseph S. Myers
joseph@codesourcery.com