This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3] Remove defines to builtins in string2.h


On 11/22/2016 10:15 PM, Wilco Dijkstra wrote:
Florian Weimer wrote:

-#ifndef _HAVE_STRING_ARCH_strchr
-# define strchr(s, c) __builtin_strchr (s, c)
-#endif

Current master has this:
...
So I'm afraid the patch doesn't apply.

Yes there is overlap with this patch: https://sourceware.org/ml/libc-alpha/2016-11/msg00586.html
(a previous version of that was posted back in February...). This particular
change could be rolled back into the original strchr patch to avoid this conflict.

Please consolidate the two into a single patch, and make sure it applies before resubmitting it.

We really should test this patch on x86 and s390.

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]