This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Install libm.a as linker script [BZ #20539]
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Andrew Senkevich <andrew dot n dot senkevich at gmail dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>
- Date: Mon, 14 Nov 2016 11:21:59 -0800
- Subject: Re: [PATCH] Install libm.a as linker script [BZ #20539]
- Authentication-results: sourceware.org; auth=none
- References: <CAMXFM3szvCP13C1P_Ed8NVV_FTt4Q8avz4uW-a=UbpWqMnF5aw@mail.gmail.com> <CAMe9rOqirjhp+cpWGTVeQKd8p-yNdsO=mQ+-Ww-B4ULSjfUSWA@mail.gmail.com> <CAMXFM3vFaa8oxD6Ep8Ou_ROO8ZW0oLPORwT5QtgxWL1QB+BmHQ@mail.gmail.com>
On Mon, Nov 14, 2016 at 11:15 AM, Andrew Senkevich
<andrew.n.senkevich@gmail.com> wrote:
> 2016-10-25 1:02 GMT+03:00 H.J. Lu <hjl.tools@gmail.com>:
>>> diff --git a/Makerules b/Makerules
>>> index e865782..290f927 100644
>>> --- a/Makerules
>>> +++ b/Makerules
>>> @@ -1190,7 +1190,9 @@ $(addprefix $(inst_sbindir)/,$(install-sbin)): \
>>> $(do-install-program)
>>> endif
>>> ifdef install-lib
>>> -install-lib.a := $(filter lib%.a,$(install-lib))
>>> +ifeq ($(build-mathvec),yes)
>>> +install-lib.a := $(filter-out libm.a,$(filter lib%.a,$(install-lib)))
>>> +endif
>>
>> Should we use $(install-lib-ldscripts) instead of libm.a here?
>
> I had tried but haven't rich a success.
Did you add libm.a to install-lib-ldscripts?
>>> # Rules for the test suite.
>>>
>>
>> Do you need to update rules for building static math tests with
>> libmvec.a?
>
> I haven't added -lmvec explicitly for any static math test so I think no.
Static math test in glibc may fail if the same bug is triggered
with ether new GCC or new test.
> Attached corrected version.
>
echo 'GROUP ( $(inst_libdir)/libm-$(lib-version).a $(inst_libdir)/libmvec.a )' \
^^^^^^^^^^^^ Please use libdir here.
--
H.J.