This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v6 1/3] Add strfromd, strfromf, and strfroml functions


On 10/05/2016 03:19 PM, Gabriel F. T. Gomes wrote:
> ISO/IEC TS 18661-1 adds several functions in the strfrom family to stdlib.
> This patch adds strfromd, strfromf, and strfroml.  This is being done in
> preparation for the new floating-point type, float128.  The added functions
> convert a floating-point value into a string, with configurable format.
> 
> 2016-06-23  Gabriel F. T. Gomes  <gftg@linux.vnet.ibm.com>

Only one minor detail:

> diff --git a/manual/arith.texi b/manual/arith.texi
> index a13c46f..591ca40 100644
> --- a/manual/arith.texi
> +++ b/manual/arith.texi

> +zero.  The character @samp{*} is not allowed.  Finally, the format string
> +ends with one of the following conversion specifiers: @samp{a}, @samp{A},
> +@samp{e}, @samp{E}, @samp{f}, @samp{F}, @samp{g}, @samp{G} (@pxref{Table of

Should have "or" in front of last list element ("G").

> +Output Conversions}).  Invalid format strings result in undefined behavior.


Otherwise I think it looks good!  Thank you.

Rical


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]