This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Add <limits.h> integer width macros

From: Florian Weimer <fweimer at redhat dot com>
To: Paul Eggert <eggert at cs dot ucla dot edu>, Joseph Myers <joseph at codesourcery dot com>
Cc: libc-alpha at sourceware dot org
Date: Tue, 4 Oct 2016 17:28:13 +0200
Subject: Re: Add <limits.h> integer width macros
Authentication-results: sourceware.org; auth=none
References: <alpine.DEB.2.20.1609131749040.9352@digraph.polyomino.org.uk> <2bbcd0d5-c2c2-d1ba-c685-e8eb49910970@cs.ucla.edu> <alpine.DEB.2.20.1609141956250.14953@digraph.polyomino.org.uk> <9b238824-7969-1a46-cc5f-ebc3c07db1d6@cs.ucla.edu> <82bfb295-b8d9-52b2-82d1-5a4c290ec34e@cs.ucla.edu>

On 10/04/2016 05:07 PM, Paul Eggert wrote:

On 09/16/2016 05:32 PM, Paul Eggert wrote:

the patch looks good; thanks.


Unfortunately I did not check the patch thoroughly enough, as the patch
turns out to define LONG_WIDTH incorrectly on i686 with
gcc-6.2.1-2.fc26.i686, and this causes grep's 'make check' to fail
(luckily these are side tests; grep itself works fine). See:

https://bugzilla.redhat.com/show_bug.cgi?id=1381582

See comment 5 there. The problem seems to be that GCC <limits.h> isincluded first, followed by glibc <limits.h>, which then tries to getthe definitions from GCC. But at this point, nothing happens becausethe GCC include guards cause the GCC header to be skipped.

The proposed fix doesn't seem right, it would need checks for GCC andthe GCC version.


Thanks,
Florian

Follow-Ups:
- Re: Add <limits.h> integer width macros
  - From: Joseph Myers

References:
- Re: Add <limits.h> integer width macros
  - From: Paul Eggert

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]