This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH BZ#20422] Do not allow asan/msan/tsan and fortify at the same time.
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Kostya Serebryany <kcc at google dot com>
- Cc: Yuri Gribov <tetra2005 at gmail dot com>, Florian Weimer <fw at deneb dot enyo dot de>, Andrew Pinski <pinskia at gmail dot com>, Maxim Ostapenko <m dot ostapenko at samsung dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Tue, 4 Oct 2016 08:46:23 +0200
- Subject: Re: [PATCH BZ#20422] Do not allow asan/msan/tsan and fortify at the same time.
- Authentication-results: sourceware.org; auth=none
- References: <20160929100429.GQ7282@tucnak.redhat.com> <CAJOtW+5gnekVLcnUCrHWjYL1agspyZ-v_kOgEp8kyCrviGADJw@mail.gmail.com> <20160929104408.GR7282@tucnak.redhat.com> <CA+=Sn1mj83AL=XKinTbJDwOEEVReVFWTsbprKuVVMbsu=OdA7w@mail.gmail.com> <CAN=P9pjzpygMJKjUDtkKxRn4+4BDG_wJ3qbQhehSJa5UenV6gA@mail.gmail.com> <87fuofp4sq.fsf@mid.deneb.enyo.de> <20161002093953.GS7282@tucnak.redhat.com> <8760pbnl1m.fsf@mid.deneb.enyo.de> <CAJOtW+4zPuy3n7deKWGvtAs9PL1rmEua8GMG_3zW57GG6tZNSA@mail.gmail.com> <CAN=P9piFwKNNK88BbEMMT6H8S1SndzuKqK4XJVHQVA-4A3MK=g@mail.gmail.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Mon, Oct 03, 2016 at 05:52:58PM -0700, Kostya Serebryany wrote:
> >> Because you really don't know what kind of information will each tool want
> >> to know, and that can significantly differ between valgrind, [amt]san etc.
> >> In sanitizer_common, you can come up with some macros that will serve the
> >> needs of all the tools, and have each tool use those macros, other than
> >> that, it is a trivial 3 liner wrapper for each fortification function
>
> Disagree. all the sanitizers will want to be directed to the original functions.
> Valgrind most likely too.
At least in my understanding, valgrind doesn't want that, it wants to be
able to nicely diagnose the error and for that it needs all the information
about the reason. It has the ability to override calls that don't go through
PLT symbols already.
Jakub