This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 3/4] Use copysign instead of ternary conditions for positive constants

From: Carlos O'Donell <carlos at redhat dot com>
To: Siddhesh Poyarekar <siddhesh at sourceware dot org>, libc-alpha at sourceware dot org
Date: Wed, 28 Sep 2016 15:58:35 -0400
Subject: Re: [PATCH 3/4] Use copysign instead of ternary conditions for positive constants
Authentication-results: sourceware.org; auth=none
References: <1474998553-2366-1-git-send-email-siddhesh@sourceware.org> <1474998553-2366-4-git-send-email-siddhesh@sourceware.org>

On 09/27/2016 01:49 PM, Siddhesh Poyarekar wrote:
> This is the first very simple substitution of ternary conditions for
> correction adjustments with __copysign for positive constants.
> 
> 	* sysdeps/ieee754/dbl-64/s_sin.c (do_cos_slow): use copysign
> 	instead of ternary condition.
> 	(do_sin_slow): Likewise.
> 	(do_sincos_1): Likewise.
> 	(do_sincos_2): Likewise.
> 	(__cos): Likewise.
> 	(sloww): Likewise.
> 	(sloww1): Likewise.
> 	(sloww2): Likewise.
> 	(bsloww): Likewise.
> 	(bsloww1): Likewise.
> 	(bsloww2): Likewise.

LGTM.

-- 
Cheers,
Carlos.

References:
- [PATCH 0/4] Use __copysign in sincos wherever possible
  - From: Siddhesh Poyarekar
- [PATCH 3/4] Use copysign instead of ternary conditions for positive constants
  - From: Siddhesh Poyarekar

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]