This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 05/13] Installed header hygiene (BZ#20366): BYTE_ORDER macros.
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Zack Weinberg <zackw at panix dot com>, libc-alpha at sourceware dot org
- Cc: joseph at codesourcery dot com
- Date: Wed, 21 Sep 2016 13:56:08 -0400
- Subject: Re: [PATCH 05/13] Installed header hygiene (BZ#20366): BYTE_ORDER macros.
- Authentication-results: sourceware.org; auth=none
- References: <20160830011645.25769-1-zackw@panix.com> <20160830011645.25769-2-zackw@panix.com> <20160830011645.25769-3-zackw@panix.com> <20160830011645.25769-4-zackw@panix.com> <20160830011645.25769-5-zackw@panix.com> <20160830011645.25769-6-zackw@panix.com>
On 08/29/2016 09:16 PM, Zack Weinberg wrote:
> <endian.h> only defines BYTE_ORDER, BIG_ENDIAN, LITTLE_ENDIAN,
> etc. under __USE_MISC; glibc's headers should use __BYTE_ORDER,
> __BIG_ENDIAN, __LITTLE_ENDIAN, etc. instead.
>
> * inet/netinet/icmp6.h, inet/netinet/ip6.h
> * resolv/arpa/nameser_compat.h:
> Use __BYTE_ORDER etc. instead of BYTE_ORDER etc.
It is conceivable that much of what is in these headers is only
usable with __USE_MISC, but it should still get cleaned up.
LGTM.
--
Cheers,
Carlos.