This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [06/12] Add femode_t functions: ia64
- From: Yury Norov <ynorov at caviumnetworks dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: <libc-alpha at sourceware dot org>, <vapier at gentoo dot org>
- Date: Sat, 3 Sep 2016 17:25:50 +0300
- Subject: Re: [06/12] Add femode_t functions: ia64
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Yuri dot Norov at caviumnetworks dot com;
- References: <alpine.DEB.2.20.1609022156090.4311@digraph.polyomino.org.uk>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On Fri, Sep 02, 2016 at 09:56:42PM +0000, Joseph Myers wrote:
[...]
> diff --git a/sysdeps/ia64/fpu/fesetmode.c b/sysdeps/ia64/fpu/fesetmode.c
> new file mode 100644
> index 0000000..11187e9
> --- /dev/null
> +++ b/sysdeps/ia64/fpu/fesetmode.c
> @@ -0,0 +1,42 @@
> +/* Install given floating-point control modes. IA64 version.
> + Copyright (C) 2016 Free Software Foundation, Inc.
> + This file is part of the GNU C Library.
> +
> + The GNU C Library is free software; you can redistribute it and/or
> + modify it under the terms of the GNU Lesser General Public
> + License as published by the Free Software Foundation; either
> + version 2.1 of the License, or (at your option) any later version.
> +
> + The GNU C Library is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + Lesser General Public License for more details.
> +
> + You should have received a copy of the GNU Lesser General Public
> + License along with the GNU C Library; if not, see
> + <http://www.gnu.org/licenses/>. */
> +
> +#include <fenv.h>
> +
> +#define FPSR_STATUS 0x1f80UL
> +#define FPSR_STATUS_ALL ((FPSR_STATUS << 6) | (FPSR_STATUS << 19) \
> + | (FPSR_STATUS << 32) | (FPSR_STATUS << 45))
> +
Hi Josepf,
Is it possible to #define offsets to avoid magic numbers, or drop the
link to specification?
Yury.
> +int
> +fesetmode (const femode_t *modep)
> +{
> + femode_t mode;
> +
> + /* As in fesetenv. */
> + if (((fenv_t) modep >> 62) == 0x03)
> + mode = (femode_t) modep & 0x3fffffffffffffffUL;
> + else
> + mode = *modep;
> +
> + femode_t fpsr;
> + __asm__ __volatile__ ("mov.m %0=ar.fpsr" : "=r" (fpsr));
> + fpsr = (fpsr & FPSR_STATUS_ALL) | (mode & ~FPSR_STATUS_ALL);
> + __asm__ __volatile__ ("mov.m ar.fpsr=%0;;" :: "r" (fpsr));
> +
> + return 0;
> +}
>
> --
> Joseph S. Myers
> joseph@codesourcery.com