This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/5] Consolidate reduce_and_compute code

From: Joseph Myers <joseph at codesourcery dot com>
To: Siddhesh Poyarekar <siddhesh at sourceware dot org>
Cc: <libc-alpha at sourceware dot org>
Date: Mon, 29 Aug 2016 16:03:05 +0000
Subject: Re: [PATCH 1/5] Consolidate reduce_and_compute code
Authentication-results: sourceware.org; auth=none
References: <1471976565-3576-1-git-send-email-siddhesh@sourceware.org> <1471976565-3576-2-git-send-email-siddhesh@sourceware.org>

On Tue, 23 Aug 2016, Siddhesh Poyarekar wrote:

> +    case 2:
> +      a = -a;
> +      da = -da;
> +    case 0:

OK with a comment on this fallthrough (we might want to use the 
-Wimplicit-fallthrough being proposed for GCC 7...).

-- 
Joseph S. Myers
joseph@codesourcery.com

Follow-Ups:
- Re: [PATCH 1/5] Consolidate reduce_and_compute code
  - From: Siddhesh Poyarekar

References:
- [PATCH 0/5] sin/cos/sincos cleanups
  - From: Siddhesh Poyarekar
- [PATCH 1/5] Consolidate reduce_and_compute code
  - From: Siddhesh Poyarekar

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]