This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Sync proc_service.h ps_get_thread_area definition with GDB
On 17/08/2016 17:04, Tom Tromey wrote:
>>>>>> "Adhemerval" == Adhemerval Zanella <adhemerval.zanella@linaro.org> writes:
>
> Adhemerval> Commit "Update and install proc_service.h [BZ #20311]" (b381a388) removed
> Adhemerval> some extraneous 'const' from ps_{s,l}{stop,continue}, however it wrongly
> Adhemerval> removed 'const' from ps_get_thread_area. With current definition GDB
> Adhemerval> fails to build against glibc master with a conflicting type.
>
> This was intentional, see comment #15.
>
> The idea is that it doesn't make sense for libthread_db to decide that
> the argument must be const -- the implementer might want to modify the
> object for some reason.
>
> I think it would be more correct to change gdb.
>
> Tom
>
I do not have a strong preference here and it seems it would be
feasible to remove constness from GDB. I check on GDB side then.