This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] argp: Do not override GCC keywords with macros [BZ #16907]


On 08/15/2016 09:06 AM, Paul Eggert wrote:
Florian Weimer wrote:

#ifndef _GL_INLINE_HEADER_BEGIN
 #error "Please include config.h first."
#endif

This will result in an #error if the installed header <argp.h> is used by
applications.

Then let's remove those three lines. They are not essential for Gnulib,
and staying in sync with glibc is more important than the extra
error-checking they might provide for Gnulib users.

We also have to adjust the use of the macros _GL_INLINE_HEADER_BEGIN, _GL_INLINE_HEADER_END, and _GL_INLINE. The gnulib version currently assumes that _LIBC is always defined for a glibc header, which is not true when the header is installed.

I would like to use the minimal patch as a start. We can sync with gnulib once it has fixed the non-gnulib, !_LIBC case.

Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]