This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCHv2 03/11] Support for type-generic libm function implementations libm
On Wed, 10 Aug 2016, Paul E. Murphy wrote:
> Thinking on Carlos' comments regarding tst-wcstod-round, I am wondering if
> maybe it wouldn't be better to add an extra make target which instead
> generates a .c file based on existing naming conventions. E.g:
>
> /* This file is generated by 'make regen-libm-templates. Do not edit. */
> #include <math-type-macros-${type}>
> #include <${func_unsuffixed}_template.c>
>
> This has the benefit of leaving the existing implicit override mechanism
> in place, and no insane makefile hacks. I would prefer them living in
> their own directory maybe math/generated, ensuring they are always included
> after sysdep targets.
>
> This target would not run as part of the build process. It would be invoked
> periodically as libm supports new types, or changes are needed.
Files with an explicit #include are fine as an alternative to generating
special -include options. But if you're generating them from the glibc
build system, it would be better to generate them in the build directory
rather than checking them in.
--
Joseph S. Myers
joseph@codesourcery.com