This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [2.24 PATCH 2/3] Minimize sysdeps code involved in defining major/minor/makedev.
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Zack Weinberg <zackw at panix dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, Mike Frysinger <vapier at gentoo dot org>
- Date: Wed, 3 Aug 2016 11:11:12 -0400
- Subject: Re: [2.24 PATCH 2/3] Minimize sysdeps code involved in defining major/minor/makedev.
- Authentication-results: sourceware.org; auth=none
- References: <cover.1469994984.git.zackw@panix.com> <f8c0d2303f58584f353d8c0dcc484c1ff911c299.1469994984.git.zackw@panix.com> <20d95e83-a254-e8da-60d8-6f02650fa4c2@redhat.com> <CAKCAbMj9WPT8C1rGOKndoGeOcCpnPS4dbTJ1D56jxQLtOFjKTw@mail.gmail.com>
On 08/01/2016 05:28 PM, Zack Weinberg wrote:
> On Mon, Aug 1, 2016 at 4:55 PM, Carlos O'Donell <carlos@redhat.com> wrote:
>> (3) New symbols?
>>
>> Overall this looks good. I have only questions about why the new functions
>> are going into the users namespace. Traditionally we put things into the
>> implementation namespace, particularly to discourage users calling the
>> functions directly. I would like the user to use the normal interfaces for
>> calling this functionality.
>
> I would agree if these were truly new functions, but they're not. They
> already exist, with the user-namespace names, in every Linux-based
> port. `grep gnu_dev_ $(find sysdeps -name libc*.abilist)` and see for
> yourself.
You are absolutely right. Sorry, I thought this had been inlined and the
functions not visible, but there they are at @@GLIBC_2.3.3 versions.
OK to checkin then.
--
Cheers,
Carlos.