This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Testing glibc 2.24 on remaining machines.
- From: David Miller <davem at davemloft dot net>
- To: carlos at redhat dot com
- Cc: libc-alpha at sourceware dot org, vapier at gentoo dot org, adhemerval dot zanella at linaro dot org
- Date: Mon, 01 Aug 2016 11:04:52 -0700 (PDT)
- Subject: Re: Testing glibc 2.24 on remaining machines.
- Authentication-results: sourceware.org; auth=none
- References: <521d3f7a-6375-11c7-5987-ad2f0f1ab290@redhat.com> <20160720.153931.575029361394679476.davem@davemloft.net> <8291c199-5932-d330-bc46-151d4f2cebbc@redhat.com>
From: Carlos O'Donell <carlos@redhat.com>
Date: Mon, 1 Aug 2016 11:57:16 -0400
> On 07/20/2016 06:39 PM, David Miller wrote:
>> I had to apply this (year old) patch to fix the wcsmbs comparison test
>> case. The memory compared must be aligned suitably for the type
>> being used, otherwise we get SIGBUS on platforms like sparc:
>>
>> diff --git a/string/test-strncmp.c b/string/test-strncmp.c
>> index 8c0a331..d392248 100644
>> --- a/string/test-strncmp.c
>> +++ b/string/test-strncmp.c
>> @@ -156,6 +156,9 @@ do_test_limit (size_t align1, size_t align2, size_t len, size_t n, int max_char,
>> size_t i, align_n;
>> CHAR *s1, *s2;
>>
>> + align1 &= ~(CHARBYTES - 1);
>> + align2 &= ~(CHARBYTES - 1);
>> +
>> if (n == 0)
>> {
>> s1 = (CHAR *) (buf1 + page_size);
>> @@ -204,6 +207,9 @@ do_test (size_t align1, size_t align2, size_t len, size_t n, int max_char,
>> size_t i;
>> CHAR *s1, *s2;
>>
>> + align1 &= ~(CHARBYTES - 1);
>> + align2 &= ~(CHARBYTES - 1);
>> +
>> if (n == 0)
>> return;
>
> Are you able to update the wiki page with your testing information?
> https://sourceware.org/glibc/wiki/Release/2.24
I can certainly do that.
Would you mind if I apply the above testsuite bug fix into the tree?