This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 23/23] [AARCH64] Take utmp{,x}.h from s390 port
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: Yury Norov <ynorov at caviumnetworks dot com>, Joseph Myers <joseph at codesourcery dot com>
- Cc: libc-alpha at sourceware dot org, linux-kernel at vger dot kernel dot org, arnd at arndb dot de, catalin dot marinas at arm dot com, marcus dot shawcroft at arm dot com, philb at gnu dot org, davem at davemloft dot net, szabolcs dot nagy at arm dot com, maxim dot kuvyrkov at linaro dot org, pinskia at gmail dot com, bamvor dot zhangjian at huawei dot com, schwab at suse dot de, fweimer at redhat dot com, Prasun dot Kapoor at cavium dot com, cmetcalf at mellanox dot com, hjl dot tools at gmail dot com
- Date: Tue, 28 Jun 2016 17:43:18 -0300
- Subject: Re: [PATCH 23/23] [AARCH64] Take utmp{,x}.h from s390 port
- Authentication-results: sourceware.org; auth=none
- References: <1467131978-669-1-git-send-email-ynorov at caviumnetworks dot com> <1467131978-669-24-git-send-email-ynorov at caviumnetworks dot com> <alpine dot DEB dot 2 dot 20 dot 1606281717410 dot 25214 at digraph dot polyomino dot org dot uk> <20160628175107 dot GA2262 at yury-N73SV>
On 28/06/2016 14:59, Yury Norov wrote:
> On Tue, Jun 28, 2016 at 05:18:04PM +0000, Joseph Myers wrote:
>> On Tue, 28 Jun 2016, Yury Norov wrote:
>>
>>> aarch64 and ilp32 has different size of time_t. So to have common
>>> layout for struct utmp and utmpx, corresponding headers are taken
>>> from s390 port.
>>
>> You can't #include installed headers from other ports like this; it
>> wouldn't work when using an installed library.
>>
>> --
>> Joseph S. Myers
>> joseph@codesourcery.com
>
> So I should copy? Hmm...
>
In this case yes, since the reference will be broken because the s390
won't be installed.