This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Revert __malloc_initialize_hook symbol poisoning

From: Florian Weimer <fweimer at redhat dot com>
To: Andreas Schwab <schwab at suse dot de>
Cc: libc-alpha at sourceware dot org
Date: Thu, 23 Jun 2016 17:07:18 +0200
Subject: Re: [PATCH] Revert __malloc_initialize_hook symbol poisoning
Authentication-results: sourceware.org; auth=none
References: <20160613122031 dot 80ABE4091079D at oldenburg dot str dot redhat dot com> <mvm7fdkutf3 dot fsf at hawking dot suse dot de>

On 06/20/2016 11:00 AM, Andreas Schwab wrote:

fweimer@redhat.com (Florian Weimer) writes:

It turns out the Emacs-internal malloc implementation uses
__malloc_* symbols.  If glibc poisons them in <stdc-pre.h>,
Emacs will no longer compile.


Please install.  I don't think we should be in the business of poisoning
identifiers, even if they are in the implementation name space.

It is the only way to remove a symbol from the API which is used viainterposition, which is why I went down this route in this case.

I would have done this for the other malloc hooks, but it would stillbreak Emacs compatibility, so I'm just going to remove them from the header.


Florian

References:
- [PATCH] Revert __malloc_initialize_hook symbol poisoning
  - From: Florian Weimer
- Re: [PATCH] Revert __malloc_initialize_hook symbol poisoning
  - From: Andreas Schwab

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]