This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 04/27] [AARCH64] Add PTR_REG, PTR_LOG_SIZE, and PTR_SIZE. Use it in LDST_PCREL and LDST_GLOBAL.
- From: Yury Norov <ynorov at caviumnetworks dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: <libc-alpha at sourceware dot org>, <linux-kernel at vger dot kernel dot org>, <arnd at arndb dot de>, <catalin dot marinas at arm dot com>, <marcus dot shawcroft at arm dot com>, <philb at gnu dot org>, <davem at davemloft dot net>, <szabolcs dot nagy at arm dot com>, <maxim dot kuvyrkov at linaro dot org>, <joseph at codesourcery dot com>, <pinskia at gmail dot com>, Andrew Pinski <apinski at cavium dot com>
- Date: Tue, 21 Jun 2016 11:36:32 +0300
- Subject: Re: [PATCH 04/27] [AARCH64] Add PTR_REG, PTR_LOG_SIZE, and PTR_SIZE. Use it in LDST_PCREL and LDST_GLOBAL.
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp dot mailfrom=Yuri dot Norov at caviumnetworks dot com;
- References: <1466485631-3532-1-git-send-email-ynorov at caviumnetworks dot com> <1466485631-3532-6-git-send-email-ynorov at caviumnetworks dot com> <mvmporbrn7c dot fsf at hawking dot suse dot de>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On Tue, Jun 21, 2016 at 09:54:47AM +0200, Andreas Schwab wrote:
> Yury Norov <ynorov@caviumnetworks.com> writes:
>
> > diff --git a/sysdeps/aarch64/sysdep.h b/sysdeps/aarch64/sysdep.h
> > index 4cb028f..f2ea821 100644
> > --- a/sysdeps/aarch64/sysdep.h
> > +++ b/sysdeps/aarch64/sysdep.h
> > @@ -23,10 +23,16 @@
> >
> > #ifdef __LP64__
> > #define AARCH64_R(NAME) R_AARCH64_ ## NAME
> > +#define PTR_REG(n) x##n
> > +#define PTR_LOG_SIZE 3
> > #else
> > #define AARCH64_R(NAME) R_AARCH64_P32_ ## NAME
> > +#define PTR_REG(n) w##n
> > +#define PTR_LOG_SIZE 2
> > #endif
> >
> > +#define PTR_SIZE (1<<PTR_LOG_SIZE)
> > +
> > #ifdef __ASSEMBLER__
> >
> > /* Syntactic details of assembler. */
> > @@ -87,16 +93,18 @@
> > # define L(name) .L##name
> > #endif
> >
> > -/* Load or store to/from a pc-relative EXPR into/from R, using T. */
> > -#define LDST_PCREL(OP, R, T, EXPR) \
> > - adrp T, EXPR; \
> > - OP R, [T, #:lo12:EXPR];\
> > -
> > -/* Load or store to/from a got-relative EXPR into/from R, using T. */
> > -#define LDST_GLOBAL(OP, R, T, EXPR) \
> > - adrp T, :got:EXPR; \
> > - ldr T, [T, #:got_lo12:EXPR];\
> > - OP R, [T];
> > +/* Load or store to/from a pc-relative EXPR into/from R, using T.
> > + Note R and T are register numbers and not register names. */
> > +#define LDST_PCREL(OP, R, T, EXPR) \
> > + adrp x##T, EXPR; \
> > + OP PTR_REG (R), [x##T, #:lo12:EXPR]; \
> > +
> > +/* Load or store to/from a got-relative EXPR into/from R, using T.
> > + Note R and T are register numbers and not register names. */
> > +#define LDST_GLOBAL(OP, R, T, EXPR) \
> > + adrp x##T, :got:EXPR; \
> > + ldr PTR_REG (T), [x##T, #:got_lo12:EXPR]; \
> > + OP x##R, [x##T];
>
> I think this needs to be PTR_REG(x).
>
> Andreas.
Hi Andreas,
Thanks a lot for review. I will handle your comments and send new
version soon, maybe tomorrow.