This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] test-skeleton: redirect stderr to stdout
- From: Andreas Schwab <schwab at suse dot de>
- To: Zack Weinberg <zackw at panix dot com>
- Cc: Mike Frysinger <vapier at gentoo dot org>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 16 Jun 2016 14:56:40 +0200
- Subject: Re: [PATCH] test-skeleton: redirect stderr to stdout
- Authentication-results: sourceware.org; auth=none
- References: <1466052483-27705-1-git-send-email-vapier at gentoo dot org> <CAKCAbMgz7bkPxyRgxvgqSbHPpqo-irqKwq0wVYPL6z+-6NGzkA at mail dot gmail dot com>
Zack Weinberg <zackw@panix.com> writes:
> On Thu, Jun 16, 2016 at 12:48 AM, Mike Frysinger <vapier@gentoo.org> wrote:
>> + fclose (stderr);
>> + dup2 (STDOUT_FILENO, STDERR_FILENO);
>> + stderr = fdopen (STDERR_FILENO, "w");
>
> Wouldn't the dup2 be sufficient by itself? And then you don't have to
> worry about allocation failure in fdopen.
>
> Also a setbuf(stderr, NULL) is probably appropriate.
Also, assigning stderr is a nono.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."