This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v4] When using the Mozilla NSS library for cryptography, include the NSPR header files
- From: Guido Trentalancia <guido at trentalancia dot net>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: GLIBC Devel <libc-alpha at sourceware dot org>
- Date: Sat, 11 Jun 2016 13:55:57 +0200
- Subject: Re: [PATCH v4] When using the Mozilla NSS library for cryptography, include the NSPR header files
- Authentication-results: sourceware.org; auth=none
- References: <1464696577 dot 24965 dot 16 dot camel at trentalancia dot net> <1464698125 dot 24965 dot 18 dot camel at trentalancia dot net> <1464717048 dot 2379 dot 43 dot camel at trentalancia dot net> <1464722725 dot 2379 dot 62 dot camel at trentalancia dot net> <20160611060459 dot GK4053 at vapier dot lan>
Hello Mike.
On Sat, 11/06/2016 at 02.04 -0400, Mike Frysinger wrote:
> On 31 May 2016 21:25, Guido Trentalancia wrote:
> > When configuring and building GNU libc using the Mozilla NSS
> > library
> > for cryptography (--enable-nss-crypt option), also include the
> > NSPR header files along with the Mozilla NSS library header files.
> >
> > Finally, when running the check-local-headers test, ignore the
> > Mozilla NSPR library header files (used by the Mozilla NSS library)
> > as otherwise false positives (FAIL) are obtained.
>
> imo, we should switch to pkg-config, and then probe nss via that.
> then we don't have to know or care about nspr requirements.
> -mike
Such approach suffers the same problem as theÂ{nss,nspr}-config
scripts: you need to use pkg-config data from both NSS *and* NSPR in
orderÂto get all the needed header files' paths.
So, it won't bring any added benefit, at the expense of increased
complexity: not advisable as a first choice in my opinion, perhaps only
as a fall-back choice if {nss,nspr}-config scripts are not available on
the system...
Regards,
Guido