This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH v2] [BZ 17956] Fix build failure due to missing definitions from header file nss/nss.h when Mozilla NSS is used for cryptography
- From: Guido Trentalancia <guido at trentalancia dot net>
- To: Carlos O'Donell <carlos at redhat dot com>, Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, libc-alpha at sourceware dot org
- Date: Tue, 31 May 2016 19:00:39 +0200
- Subject: Re: [PATCH v2] [BZ 17956] Fix build failure due to missing definitions from header file nss/nss.h when Mozilla NSS is used for cryptography
- Authentication-results: sourceware.org; auth=none
- References: <1464635653 dot 24965 dot 5 dot camel at trentalancia dot net> <1464700854 dot 24965 dot 21 dot camel at trentalancia dot net> <574DA91E dot 9040508 at linaro dot org> <1464708782 dot 2379 dot 12 dot camel at trentalancia dot net> <574DB2E3 dot 4020405 at redhat dot com>
On Tue, 31/05/2016 at 11.50 -0400, Carlos O'Donell wrote:
> On 05/31/2016 11:33 AM, Guido Trentalancia wrote:
> > Please let me know if the ChangeLog is required for the first two
> > patches and I will be glad to prepare one (what has been changed is
> > trivial and explained in the header of each patch).
> Adhemerval or myself can write the ChangeLog for you as a first time
> The real issue is that I don't think your patch are quite correct
> or we haven't found the real cause of the failure.
> On Fedora we use --enable-nss-crypt for all of our builds and see
> no problems.
> You add nss3/nspr include directories to CFLAGS, which should not
> be needed.
It is needed because the configure test program usesÂhasht.h
(andÂnsslowhash.h) from the Mozilla NSS library which has the following
That is why, unless Mozilla NSPR changes the above to:
the configure test program from GNU libc fails to compile.
I bet in Fedora you have patched with sed the Mozilla NSS header files
so that they include <nspr/prtypes.h> instead of "prtypes.h"...?
> Your configure fails if you don't, and *that* is the key problem
> we should be looking at.
> The NSS headers are derived from calling, as they should:
> nss-config --includedir
> And that is used everywhere it is needed.
> So the fault appears to be in your nss-config?
> What does your failing config.log show?
It shows that the configure test program does not compile because it
cannot source the required Mozilla NSPR header file.
> What does `nss-config --includedir` print on your system?
It prints the correct location of Mozilla NSS header files (but
notÂthose of Mozilla NSPR header files which are sources without the
It might be a bug with the Mozilla NSS header files, however applying
the patches to GNU libc won't hurt I suppose. When using the latest
versions of the three patches, I get no new test failures and in
particular, no test failures within the nss or crypt components.
So, what should we do ? If you are willing to accept the changes as a safety precaution even though it might be a bug in the Mozilla NSS header files, then I can write the ChangeLog, otherwise it doesn't matter.