This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCHv3 03/11] Refactor M_ macros defined in libm-test.inc
- From: Joseph Myers <joseph at codesourcery dot com>
- To: "Paul E. Murphy" <murphyp at linux dot vnet dot ibm dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Thu, 26 May 2016 23:14:41 +0000
- Subject: Re: [PATCHv3 03/11] Refactor M_ macros defined in libm-test.inc
- Authentication-results: sourceware.org; auth=none
- References: <cover dot 1464297421 dot git dot murphyp at linux dot vnet dot ibm dot com> <44e4b7be80d0add33eca63962cf5aa21d469db2e dot 1464297421 dot git dot murphyp at linux dot vnet dot ibm dot com>
On Thu, 26 May 2016, Paul E. Murphy wrote:
> +/* (pi * 3 * ln(10) / 4 */
> +#define lit_pi_3_m_ln10_m_4_d LIT (1.023282265381381010614337719073516828)
You're missing a ')' in the comment. And, the comment, and thus the macro
name according to your scheme, are inaccurate; this one involves dividing
by ln(10), not multiplying by it (all the ln(10) ones are for clog10
expectations).
--
Joseph S. Myers
joseph@codesourcery.com