This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCHv2] Refactor tst-strtod-round.c for type-generic-ness


On Wed, 25 May 2016, Paul E. Murphy wrote:

> +/* Define the long double choose (CHOOSE_ld) macro
> +   to select the appropriate generated long double
> +   value from the generated test data.  */
>  #if LDBL_MANT_DIG == 53 && LDBL_MAX_EXP == 1024
> -# define TEST(s, fexact, fd, fn, fz, fu, dexact, dd, dn, dz, du,	\
> -	      ld53exact, ld53d, ld53n, ld53z, ld53u,			\
> -	      ld64iexact, ld64id, ld64in, ld64iz, ld64iu,		\
> -	      ld64mexact, ld64md, ld64mn, ld64mz, ld64mu,		\
> -	      ld106exact, ld106d, ld106n, ld106z, ld106u,		\
> -	      ld113exact, ld113d, ld113n, ld113z, ld113u)		\
> -  {									\
> -    s,									\
> -    { fexact, dexact, ld53exact },					\
> -    { fd, dd, ld53d },							\
> -    { fn, dn, ld53n },							\
> -    { fz, dz, ld53z },							\
> -    { fu, du, ld53u }							\
> -  }
> +/* This is for the long double == double format.  */
> +#define CHOOSE_ld(f,d,...) d

Preprocessor directives inside preprocessor conditionals should have 
appropriate indentation after the '#', so "# define CHOOSE_ld" for all the 
CHOOSE_ld definitions.

OK with that fixed.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]