This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCHv2 06/14] Replace M_PI2l with pi_2_d in

On 05/23/2016 11:56 AM, Joseph Myers wrote:
> On Fri, 20 May 2016, Paul E. Murphy wrote:
>> This is useful in situations where the long double type is
>> less precise than the type under test.
>> 	* Replace usage of M_PI2l with
>> 	[pi_2_d]: New macro.
> I'm not convinced that adding several extra local constants is the right 
> approach here.
> For the API for float128 to be feature-complete compared to long double, 
> it should include constants such as M_PI_2f128 for all the long double 
> constants in <math.h>.  Which means that there is always a constant from 
> <math.h> that can be used in these cases; you don't need yet another copy 
> of the digits of this constant.  You might, for example, have a macro MCST 
> defined for each type and use MCST (PI_2) here (which would expand to 
> M_PI_2 for float and double - there aren't float versions of these 
> <math.h> constants - M_PI_2l for long double, M_PI_2f128 for float128).

Are you suggesting removing the new constants entirely, or just redefining
these macros in terms of existing macros?

I'd prefer to keep the M prefixed constants out of the individual test cases,
and maintain consistency with the other lower case constants.  It's too easy
to overlook them otherwise.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]