This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 4/8] Add LIT() around literals in check_ulp in libm-tests.inc
- From: Joseph Myers <joseph at codesourcery dot com>
- To: "Paul E. Murphy" <murphyp at linux dot vnet dot ibm dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Wed, 18 May 2016 21:19:40 +0000
- Subject: Re: [PATCH 4/8] Add LIT() around literals in check_ulp in libm-tests.inc
- Authentication-results: sourceware.org; auth=none
- References: <cover dot 1463599718 dot git dot murphyp at linux dot vnet dot ibm dot com> <be245395cdf20cd5c966d04902a46740bf3e681f dot 1463599718 dot git dot murphyp at linux dot vnet dot ibm dot com>
On Wed, 18 May 2016, Paul E. Murphy wrote:
> - ulps = ulp (0x0.0p0);
> + ulps = ulp (LIT (0x0.0p0));
But ulp is a function and implicitly converts its argument. You don't
need the suffixes. Just passing an integer 0 or 1 in these cases and
relying on implicit conversions seems best, to make the code less
macro-heavy.
--
Joseph S. Myers
joseph@codesourcery.com